azurerm_security_center_setting - Support for Sentinel security setting in resource azurerm_security_center_setting
#16882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Comment on lines
+54
to
+63
| "kind": { | ||
| Type: pluginsdk.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| Default: security.KindDataExportSettings, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| string(security.KindDataExportSettings), | ||
| string(security.KindAlertSyncSettings), | ||
| }, false), | ||
| }, |
There was a problem hiding this comment.
rather than exposing a kind field this wants to be split into two different resources - as the discriminator implementations have different validation requirements etc
can you take a look into splitting these out @sinbai?
sinbai
changed the title
azurerm_security_center_setting - Support for Sentinel security setting in resource azurerm_security_center_setting
|
@sinbai - i'm going to close this as its been 3 months without any activity - please do re open this when its ready for review again! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #16846.
Test Results: